Skip to content

[SPARK-8203] [SPARK-8204] [SQL] conditional function: least/greatest #6851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adrian-wang wants to merge 6 commits into from
Closed

[SPARK-8203] [SPARK-8204] [SQL] conditional function: least/greatest #6851

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ec625b0
conditional function: least/greatest
adrian-wang Jun 17, 2015
c1f6824
add codegen, test for all types
adrian-wang Jul 9, 2015
7a6bdbb
add '.' for hex()
adrian-wang Jul 10, 2015
0f1bff2
address comments from davis
adrian-wang Jul 13, 2015
86fb049
use seq for case class
adrian-wang Jul 13, 2015
22e8f3d
use seq for case class in functions
adrian-wang Jul 13, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use seq for case class
  • Loading branch information
@adrian-wang
adrian-wang committed Jul 13, 2015
commit 86fb049829b8393892d6fc0b7b47e21879fe8b20
4 changes: 2 additions & 2 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionals.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ case class CaseKeyWhen(key: Expression, branches: Seq[Expression]) extends CaseW
}
}

case class Least(children: Expression*) extends Expression {
case class Least(children: Seq[Expression]) extends Expression {
Copy link
Contributor

@rxin rxin Jul 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add scaladoc explaining the semantics of this expression? also do it for greatest.

require(children.length > 1, "LEAST requires at least 2 arguments, got " + children.length)

override def nullable: Boolean = children.forall(_.nullable)
Copy link
Contributor

@rxin rxin Jul 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't least be nullable if any is nullable?

Copy link
Contributor Author

@adrian-wang adrian-wang Jul 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hive 1.2.0 only return null when all arguments are null.

Copy link
Contributor

@davies davies Jul 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If any child is not nullable, the result will not be nullable.

Expand Down Expand Up @@ -364,7 +364,7 @@ case class Least(children: Expression*) extends Expression {
}
}

case class Greatest(children: Expression*) extends Expression {
case class Greatest(children: Seq[Expression]) extends Expression {
require(children.length > 1, "GREATEST requires at least 2 arguments, got " + children.length)

override def nullable: Boolean = children.forall(_.nullable)
Expand Down