Skip to content

Conversation

@zsxwing
Copy link
Member

@zsxwing zsxwing commented Jun 18, 2015

This is a follow up PR for #6456 to make AppendOnlyMap consistent with OpenHashSet.

/cc @srowen @andrewor14

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this doesn't have the same overflow issue if the max is 2^29, OK. Yes nice to try to make these a little more consistent.

@SparkQA
Copy link

SparkQA commented Jun 18, 2015

Test build #35121 has finished for PR 6879 at commit dd4385b.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 18, 2015

Test build #35123 has finished for PR 6879 at commit 912c0ad.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zsxwing
Copy link
Member Author

zsxwing commented Jun 18, 2015

retest this please

@SparkQA
Copy link

SparkQA commented Jun 18, 2015

Test build #35124 has finished for PR 6879 at commit 912c0ad.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@asfgit asfgit closed this in 93360dc Jun 19, 2015
@zsxwing zsxwing deleted the append-only-map branch June 19, 2015 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants