Skip to content

[SPARK-8446] [SQL] Add helper functions for testing SparkPlan physical operators #6885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoshRosen wants to merge 8 commits into from
Closed

[SPARK-8446] [SQL] Add helper functions for testing SparkPlan physical operators #6885

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a46144a
WIP
JoshRosen Jun 17, 2015
996332a
Add types so that tests compile
JoshRosen Jun 18, 2015
c60a44d
Manually bind references
JoshRosen Jun 18, 2015
d9ab1e4
Add simple resolver
marmbrus Jun 18, 2015
a80f9b0
Merge pull request #4 from marmbrus/pr/6885
JoshRosen Jun 18, 2015
ae1896b
Provide implicits automatically
JoshRosen Jun 18, 2015
84214be
Add an extra column which isn't part of the sort
JoshRosen Jun 18, 2015
f8ce275
Fix some IntelliJ inspections and delete some dead code
JoshRosen Jun 18, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Manually bind references
  • Loading branch information
@JoshRosen
JoshRosen committed Jun 18, 2015
commit c60a44d4c9b59a613764484dedbe1cbbc514ad9b
8 changes: 4 additions & 4 deletions sql/core/src/test/scala/org/apache/spark/sql/execution/SortSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@

package org.apache.spark.sql.execution

import org.apache.spark.sql.catalyst.dsl.expressions._
import org.apache.spark.sql.catalyst.expressions.{Ascending, SortOrder}
import org.apache.spark.sql.catalyst.expressions.{BoundReference, Ascending, SortOrder}
import org.apache.spark.sql.types.{IntegerType, StringType}

class SortSuite extends SparkPlanTest {

Expand All @@ -31,8 +31,8 @@ class SortSuite extends SparkPlanTest {
)

val sortOrder = Seq(
SortOrder('_1, Ascending),
SortOrder('_2, Ascending)
SortOrder(BoundReference(0, StringType, nullable = false), Ascending),
Copy link
Contributor Author

@JoshRosen JoshRosen Jun 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a little annoying to have to manually bind these references. It would be nice if there was some sort of rewrite that I could use that would bind references like '_1 to the proper columns.

SortOrder(BoundReference(1, IntegerType, nullable = false), Ascending)
)

checkAnswer(
Expand Down
2 changes: 1 addition & 1 deletion sql/core/src/test/scala/org/apache/spark/sql/execution/SparkPlanTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ class SparkPlanTest extends SparkFunSuite {
planFunction: SparkPlan => SparkPlan,
expectedAnswer: Seq[A]): Unit = {
val inputDf = TestSQLContext.createDataFrame(input)
val expectedRows = expectedAnswer.map(t => Row.apply(t))
val expectedRows = expectedAnswer.map(Row.fromTuple)
SparkPlanTest.checkAnswer(inputDf, planFunction, expectedRows) match {
case Some(errorMessage) => fail(errorMessage)
case None =>
Expand Down