Skip to content

[SPARK-8227][SQL]Add function unhex #7113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhichao-li wants to merge 8 commits into from
Closed

[SPARK-8227][SQL]Add function unhex #7113

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c852d46
Add function unhex
zhichao-li Jun 30, 2015
11945c7
style
zhichao-li Jun 30, 2015
cde73f5
update to use AutoCastInputTypes
zhichao-li Jun 30, 2015
bffd37f
change to use Hex in apache common package
zhichao-li Jul 1, 2015
607d7a3
use checkInputTypes
zhichao-li Jul 1, 2015
fe5c14a
add todigit
zhichao-li Jul 1, 2015
a4ae6dc
add udf_unhex to whitelist
zhichao-li Jul 1, 2015
379356e
remove exception checking
zhichao-li Jul 2, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update to use AutoCastInputTypes
  • Loading branch information
@zhichao-li
zhichao-li committed Jun 30, 2015
commit cde73f57600bc83f89c9614bfdc690bf5e970895
2 changes: 1 addition & 1 deletion sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ case class Pow(left: Expression, right: Expression)
* Resulting characters are returned as a byte array.
*/
case class UnHex(child: Expression)
extends UnaryExpression with ExpectsInputTypes with Serializable {
extends UnaryExpression with AutoCastInputTypes with Serializable {
Copy link
Contributor

@davies davies Jul 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think unhex only works on StringType, so we should not use AutoCastInputTypes here, we should use checkInputDataTypes instead.


override def expectedChildTypes: Seq[DataType] = Seq(StringType)
Copy link
Contributor

@tarekbecker tarekbecker Jul 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davies this could be changed to ByteType, couldn't it? This avoids a cast, if someone calls this with a byte array.

Copy link
Contributor

@davies davies Jul 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hex() return StringType, so unhex() should take StringType, not BinaryType.


Expand Down