Skip to content

[SPARK-8923] [Documentation, MLlib] Add @since tags to mllib.fpm #7341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rahulpalamuttam wants to merge 2 commits into from
Closed

[SPARK-8923] [Documentation, MLlib] Add @since tags to mllib.fpm #7341

rahulpalamuttam wants to merge 2 commits into from

Conversation

@rahulpalamuttam
Copy link
Contributor

@rahulpalamuttam rahulpalamuttam commented Jul 10, 2015

No description provided.

@mengxr
Copy link
Contributor

mengxr commented Jul 10, 2015

@rahulpalamuttam @since means the Spark version when the method was first introduced. Some of the methods under mllib.fpm should be since 1.3.0. Please check the instructions on https://issues.apache.org/jira/browse/SPARK-7751. We don't need @since tag for private methods and classes.

@rahulpalamuttam
Copy link
Contributor Author

rahulpalamuttam commented Jul 10, 2015

@mengxr I've fixed the versions and removed the tags on private methods and classes.

@mengxr
Copy link
Contributor

mengxr commented Jul 10, 2015

ok to test

@mengxr
Copy link
Contributor

mengxr commented Jul 10, 2015

LGTM pending Jenkins

@SparkQA
Copy link

SparkQA commented Jul 10, 2015

Test build #37060 has finished for PR 7341 at commit bef2843.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mengxr
Copy link
Contributor

mengxr commented Jul 10, 2015

Merged into master. Thanks!

rahulpalamuttam added a commit that referenced this pull request Jul 11, 2015
@rahulpalamuttam @mengxr
[SPARK-8923] [DOCUMENTATION, MLLIB] Add @SInCE tags to mllib.fpm
0772026 
Author: rahulpalamuttam <[email protected]>

Closes #7341 from rahulpalamuttam/TaggingMLlibfpm and squashes the following commits:

bef2843 [rahulpalamuttam] fix @SInCE tags in mmlib.fpm
cd86252 [rahulpalamuttam] Add @SInCE tags to mllib.fpm
@AmplabJenkins
Copy link

AmplabJenkins commented Jul 13, 2015

Can one of the admins verify this patch?

@stumped2
Copy link
Member

stumped2 commented Jul 16, 2015

Please do not do anything to close this PR. It is being used in a support ticket to GitHub.

@mengxr
Copy link
Contributor

mengxr commented Jul 29, 2015

@stumped2 Any update about the status?

@stumped2 stumped2 closed this Jul 29, 2015
@stumped2
Copy link
Member

stumped2 commented Jul 29, 2015

Sorry, closing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rahulpalamuttam @mengxr @SparkQA @AmplabJenkins @stumped2