Skip to content

[SPARK-6851] [SQL] function least/greatest follow up #7387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
adrian-wang wants to merge 3 commits into from
Closed

[SPARK-6851] [SQL] function least/greatest follow up #7387

adrian-wang wants to merge 3 commits into from

Conversation

@adrian-wang
Copy link
Contributor

@adrian-wang adrian-wang commented Jul 14, 2015

This is a follow up of remaining comments from #6851

@SparkQA
Copy link

SparkQA commented Jul 14, 2015

Test build #37186 has finished for PR 7387 at commit 8362966.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class Least(children: Seq[Expression]) extends Expression
    • case class Greatest(children: Seq[Expression]) extends Expression

@SparkQA
Copy link

SparkQA commented Jul 14, 2015

Test build #37195 has finished for PR 7387 at commit e8c2e09.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class Least(children: Seq[Expression]) extends Expression
    • case class Greatest(children: Seq[Expression]) extends Expression

@adrian-wang
Copy link
Contributor Author

adrian-wang commented Jul 14, 2015

retest this please.

rxin
rxin reviewed Jul 14, 2015
View reviewed changes
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionals.scala Outdated
Copy link
Contributor

@rxin rxin Jul 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it's also important to explicitly say that "least value of all parameters, skipping null values".

@SparkQA
Copy link

SparkQA commented Jul 14, 2015

Test build #10 has finished for PR 7387 at commit e8c2e09.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 14, 2015

Test build #37201 has finished for PR 7387 at commit e8c2e09.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class Least(children: Seq[Expression]) extends Expression
    • case class Greatest(children: Seq[Expression]) extends Expression

@rxin
Copy link
Contributor

rxin commented Jul 14, 2015

Thanks - merging this.

@SparkQA
Copy link

SparkQA commented Jul 14, 2015

Test build #37216 has finished for PR 7387 at commit 6163e62.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class Least(children: Seq[Expression]) extends Expression
    • case class Greatest(children: Seq[Expression]) extends Expression

adrian-wang added a commit that referenced this pull request Jul 14, 2015
@adrian-wang @rxin
[SPARK-6851] [SQL] function least/greatest follow up
257236c 
This is a follow up of remaining comments from #6851

Author: Daoyuan Wang <[email protected]>

Closes #7387 from adrian-wang/udflgfollow and squashes the following commits:

6163e62 [Daoyuan Wang] add skipping null values
e8c2e09 [Daoyuan Wang] use seq
8362966 [Daoyuan Wang] pr6851 follow up
@rxin
Copy link
Contributor

rxin commented Jul 14, 2015

@adrian-wang can you close this ticket? I believe it has been merged already but github is having issue with pr closure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adrian-wang @SparkQA @rxin