Skip to content

[Minor][SQL] Allow spaces in the beginning and ending of string for Interval #7390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
viirya wants to merge 3 commits into from
Closed

[Minor][SQL] Allow spaces in the beginning and ending of string for Interval #7390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
815a9cb
Slightly modify regex to allow spaces in the beginning and ending of …
viirya Jul 14, 2015
57861f7
Fix scala style.
viirya Jul 14, 2015
9eb6831
Use trim instead of modifying regex.
viirya Jul 14, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions unsafe/src/main/java/org/apache/spark/unsafe/types/Interval.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ public static Interval fromString(String s) {
if (s == null) {
return null;
}
s = s.trim();
Matcher m = p.matcher(s);
if (!m.matches() || s.equals("interval")) {
return null;
Expand Down
6 changes: 6 additions & 0 deletions unsafe/src/test/java/org/apache/spark/unsafe/types/IntervalSuite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,12 @@ public void fromStringTest() {
Interval result = new Interval(-5 * 12 + 23, 0);
assertEquals(Interval.fromString(input), result);

input = "interval -5 years 23 month ";
assertEquals(Interval.fromString(input), result);

input = " interval -5 years 23 month ";
assertEquals(Interval.fromString(input), result);

// Error cases
input = "interval 3month 1 hour";
assertEquals(Interval.fromString(input), null);
Expand Down