Skip to content

[SPARK-9043] Serialize key, value and combiner classes in ShuffleDependency #7403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
massie wants to merge 4 commits into from
Closed

[SPARK-9043] Serialize key, value and combiner classes in ShuffleDependency #7403

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ed1afac
[SPARK-9043] Serialize key, value and combiner classes in ShuffleDepe…
massie Jul 7, 2015
eccb0ed
Make *ClassName vals in ShuffleDependency private
massie Sep 9, 2015
2906e74
Scaladoc cleanup
massie Sep 9, 2015
adcdfaf
Mark the combineByKeyWithClassTag methods as experimental
massie Sep 10, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make *ClassName vals in ShuffleDependency private
  • Loading branch information
@massie
massie committed Sep 9, 2015
commit eccb0edceb87d5e9499a2f75cdbd234776b683c1
12 changes: 5 additions & 7 deletions core/src/main/scala/org/apache/spark/Dependency.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,15 +78,13 @@ class ShuffleDependency[K: ClassTag, V: ClassTag, C: ClassTag](

override def rdd: RDD[Product2[K, V]] = _rdd.asInstanceOf[RDD[Product2[K, V]]]

/**
* The key, value and combiner classes are serialized so that shuffle manager
* implementation can use the information to build
*/
val keyClassName: String = reflect.classTag[K].runtimeClass.getName
val valueClassName: String = reflect.classTag[V].runtimeClass.getName
private[spark] val keyClassName: String = reflect.classTag[K].runtimeClass.getName
private[spark] val valueClassName: String = reflect.classTag[V].runtimeClass.getName
// Note: It's possible that the combiner class tag is null, if the combineByKey
// methods in PairRDDFunctions are used instead of combineByKeyWithClassTag.
val combinerClassName: Option[String] = Option(reflect.classTag[C]).map(_.runtimeClass.getName)
private[spark] val combinerClassName: Option[String] =
Option(reflect.classTag[C]).map(_.runtimeClass.getName)

val shuffleId: Int = _rdd.context.newShuffleId()

val shuffleHandle: ShuffleHandle = _rdd.context.env.shuffleManager.registerShuffle(
Expand Down