Skip to content

[SPARK-9269][SQL] Add Set type matching to ArrayConverter #7628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexliu68 wants to merge 1 commit into from
Closed

[SPARK-9269][SQL] Add Set type matching to ArrayConverter #7628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[SPARK-9269][SQL] Add Set type matching to ArrayConverter
  • Loading branch information
@alexoss68
alexoss68 committed Jul 23, 2015
commit 040ce6550189932b71fc1023ec81ce8236dd675b
1 change: 1 addition & 0 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystTypeConverters.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ object CatalystTypeConverters {
scalaValue match {
case a: Array[_] => a.toSeq.map(elementConverter.toCatalyst)
case s: Seq[_] => s.map(elementConverter.toCatalyst)
case set: Set[_] => set.toSeq.map(elementConverter.toCatalyst)
case i: JavaIterable[_] =>
val iter = i.iterator
var convertedIterable: List[Any] = List()
Expand Down
6 changes: 6 additions & 0 deletions sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/CatalystTypeConvertersSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,4 +59,10 @@ class CatalystTypeConvertersSuite extends SparkFunSuite {
test("option handling in createToCatalystConverter") {
assert(CatalystTypeConverters.createToCatalystConverter(IntegerType)(Some(123)) === 123)
}

test("Set data in ArrayConverter") {
val convertToCatalyst = CatalystTypeConverters.createToCatalystConverter(ArrayType(StringType, containsNull = true))
val convertToScala = CatalystTypeConverters.createToScalaConverter(ArrayType(StringType, containsNull = true))
assert(convertToScala(convertToCatalyst(Some(Set("123", "124")))) === Seq("123", "124"))
}
}