Skip to content

[SPARK-9306][SQL] Don't use SortMergeJoin when joining on unsortable columns #7645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
viirya wants to merge 2 commits into from
Closed

[SPARK-9306][SQL] Don't use SortMergeJoin when joining on unsortable columns #7645

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55221fa
Shouldn't use SortMergeJoin when joining on unsortable columns.
viirya Jul 24, 2015
a240707
Use forall instead of exists for readability.
viirya Jul 24, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use forall instead of exists for readability.
  • Loading branch information
@viirya
viirya committed Jul 24, 2015
commit a2407074dc34672f71c33d671d285809969bfc78
8 changes: 4 additions & 4 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,11 +93,11 @@ private[sql] abstract class SparkStrategies extends QueryPlanner[SparkPlan] {
private[this] def isValidSort(
leftKeys: Seq[Expression],
rightKeys: Seq[Expression]): Boolean = {
!leftKeys.zip(rightKeys).exists { keys =>
leftKeys.zip(rightKeys).forall { keys =>
(keys._1.dataType, keys._2.dataType) match {
case (l: AtomicType, r: AtomicType) => false
case (NullType, NullType) => false
case _ => true
case (l: AtomicType, r: AtomicType) => true
case (NullType, NullType) => true
case _ => false
}
}
}
Expand Down