[SPARK-9824][Core]Fix the issue that InternalAccumulator leaks WeakReference #8108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/cc @andrewor14 |
Contributor
|
Good catch. LGTM will merge once tests pass. Thanks for fixing this. |
|
Test build #40460 timed out for PR 8108 at commit |
Contributor
|
I'm going to merge this since Jenkins actually ran all the tests. |
asfgit
pushed a commit
that referenced
this pull request
Aug 11, 2015
…Reference `InternalAccumulator.create` doesn't call `registerAccumulatorForCleanup` to register itself with ContextCleaner, so `WeakReference`s for these accumulators in `Accumulators.originals` won't be removed. This PR added `registerAccumulatorForCleanup` for internal accumulators to avoid the memory leak. Author: zsxwing <[email protected]> Closes #8108 from zsxwing/internal-accumulators-leak. (cherry picked from commit f16bc68) Signed-off-by: Reynold Xin <[email protected]>
CodingCat
pushed a commit
to CodingCat/spark
that referenced
this pull request
Aug 17, 2015
…Reference `InternalAccumulator.create` doesn't call `registerAccumulatorForCleanup` to register itself with ContextCleaner, so `WeakReference`s for these accumulators in `Accumulators.originals` won't be removed. This PR added `registerAccumulatorForCleanup` for internal accumulators to avoid the memory leak. Author: zsxwing <[email protected]> Closes apache#8108 from zsxwing/internal-accumulators-leak.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InternalAccumulator.createdoesn't callregisterAccumulatorForCleanupto register itself with ContextCleaner, soWeakReferences for these accumulators inAccumulators.originalswon't be removed.This PR added
registerAccumulatorForCleanupfor internal accumulators to avoid the memory leak.