[SPARK-9767] Remove ConnectionManager. #8161
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #40748 has finished for PR 8161 at commit
|
|
Test build #40942 has finished for PR 8161 at commit
|
|
Test build #41350 has finished for PR 8161 at commit
|
|
Test build #41844 has finished for PR 8161 at commit
|
|
Test build #1710 has finished for PR 8161 at commit
|
|
Test build #41896 has finished for PR 8161 at commit
|
We introduced the Netty network module for shuffle in Spark 1.2, and has turned it on by default for 3 releases. The old ConnectionManager is difficult to maintain. It's time to remove it for Spark 1.6.
|
Test build #42045 has finished for PR 8161 at commit
|
Contributor
Author
|
I'm going to merge this since it continuously conflict with other Mima patches. cc @tdas to take a quick look at the streaming changes, and @andrewor14 or @JoshRosen to look at rest. |
Contributor
|
LGTM to the streaming change. |
Contributor
|
Looks alright. |
markhamstra
pushed a commit
to markhamstra/spark
that referenced
this pull request
Oct 14, 2015
We introduced the Netty network module for shuffle in Spark 1.2, and has turned it on by default for 3 releases. The old ConnectionManager is difficult to maintain. If we merge the patch now, by the time it is released, it would be 1 yr for which ConnectionManager is off by default. It's time to remove it. Author: Reynold Xin <[email protected]> Closes apache#8161 from rxin/SPARK-9767.
dongjoon-hyun
added a commit
that referenced
this pull request
Oct 24, 2025
…ervice` configuration ### What changes were proposed in this pull request? This PR aims to remove no-op `spark.shuffle.blockTransferService` configuration from Apache Spark code based. ### Why are the changes needed? The configuration was removed at Apache Spark 1.6.0. - #8161 ### Does this PR introduce _any_ user-facing change? No, this is a clean up of unused test code. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #52709 from dongjoon-hyun/SPARK-54005. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
…ervice` configuration ### What changes were proposed in this pull request? This PR aims to remove no-op `spark.shuffle.blockTransferService` configuration from Apache Spark code based. ### Why are the changes needed? The configuration was removed at Apache Spark 1.6.0. - apache#8161 ### Does this PR introduce _any_ user-facing change? No, this is a clean up of unused test code. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52709 from dongjoon-hyun/SPARK-54005. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced the Netty network module for shuffle in Spark 1.2, and has turned it on by default for 3 releases. The old ConnectionManager is difficult to maintain. If we merge the patch now, by the time it is released, it would be 1 yr for which ConnectionManager is off by default. It's time to remove it.