[SPARK-9955][SQL] correct error message for aggregate

[cloud-fan]

We should skip unresolved LogicalPlans for PullOutNondeterministic, as calling output on unresolved LogicalPlan will produce confusing error message.

[cloud-fan]

cc @marmbrus @rxin

[SparkQA]

Test build #40880 has finished for PR 8203 at commit 7593080.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
  • implicit class StringToColumn(val sc: StringContext)

[marmbrus]

Can you please move this to AnalysisErrorSuite?

[cloud-fan]

The UnresolvedAlias is only introduced when parsing SQL or DataFrame, so if we move this test into AnalysisErrorSuite, we need to add the UnresolvedAliases manually, is that OK?

[marmbrus]

Or construct the plan by hand? Or we could maybe start a dataframe error
suite.
On Aug 14, 2015 8:26 PM, "Wenchen Fan" [email protected] wrote:

In sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
#8203 (comment):

• sqlContext.dropTempTable("1one")
• test("SPARK-9955: correct error message for aggregate") {
• val e = intercept[AnalysisException] {

•  sql("select key, max(value) from testData where bad_column > 1 group by key")
  

The UnresolvedAlias is only introduced when parsing SQL or DataFrame, so
if we move this test into AnalysisErrorSuite, we need to add the
UnresolvedAliases manually, is that OK?

—
Reply to this email directly or view it on GitHub
https://github.com/apache/spark/pull/8203/files#r37132757.

[SparkQA]

Test build #40951 has finished for PR 8203 at commit 1c67ca7.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[marmbrus]

Thanks! Merging to master and branch-1.5