Skip to content

Conversation

@tdas
Copy link
Contributor

@tdas tdas commented Aug 19, 2015

Small changes

  • Renamed conf spark.streaming.backpressure.{enable --> enabled}
  • Change Java Deprecated annotations to Scala deprecated annotation with more information.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The semicolons where unnecessary and was being flagged by IntelliJ

@tdas tdas changed the title [SPARK-9967][SPARK-10099][STREAMING] Small changes [SPARK-9967][SPARK-10099][STREAMING] Renamed conf spark.streaming.backpressure.{enable-->enabled} and fixed deprecated annotations Aug 19, 2015
@andrewor14
Copy link
Contributor

yes, please call it enabled instead

@tdas
Copy link
Contributor Author

tdas commented Aug 19, 2015

LGTY?

@SparkQA
Copy link

SparkQA commented Aug 19, 2015

Test build #41201 has finished for PR 8299 at commit b10b311.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • implicit class StringToColumn(val sc: StringContext)

@andrewor14
Copy link
Contributor

yeah feel free to merge (FFTM)

@srowen
Copy link
Member

srowen commented Aug 19, 2015

Oh good, I was just about to. LGTM.

@tdas
Copy link
Contributor Author

tdas commented Aug 19, 2015

The last failures was unrelated ConnectionManagerSuite (which is known to be flaky) and the currently running core tests have all passed I am merging this to master and 1.5. Thanks @andrewor14 and @srowen .

@tdas tdas closed this Aug 19, 2015
@tdas tdas reopened this Aug 19, 2015
asfgit pushed a commit that referenced this pull request Aug 19, 2015
…ackpressure.{enable-->enabled} and fixed deprecated annotations

Small changes
- Renamed conf spark.streaming.backpressure.{enable --> enabled}
- Change Java Deprecated annotations to Scala deprecated annotation with more information.

Author: Tathagata Das <[email protected]>

Closes #8299 from tdas/SPARK-9967.

(cherry picked from commit bc9a0e0)
Signed-off-by: Tathagata Das <[email protected]>
@asfgit asfgit closed this in bc9a0e0 Aug 19, 2015
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea here was that this flag hadn't been 'released' yet so OK to change the name without keeping the old one?

The two changes in the PR were pretty unrelated right? still I can't imagine someone would really care about back-porting one and not be able to consume the other as they're minor.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, for both. That's why went ahead with squashing both into one.

@SparkQA
Copy link

SparkQA commented Aug 19, 2015

Test build #1664 timed out for PR 8299 at commit b10b311 after a configured wait of 175m.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants