-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-9967][SPARK-10099][STREAMING] Renamed conf spark.streaming.backpressure.{enable-->enabled} and fixed deprecated annotations #8299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The semicolons where unnecessary and was being flagged by IntelliJ
|
yes, please call it |
|
LGTY? |
|
Test build #41201 has finished for PR 8299 at commit
|
|
yeah feel free to merge (FFTM) |
|
Oh good, I was just about to. LGTM. |
|
The last failures was unrelated ConnectionManagerSuite (which is known to be flaky) and the currently running core tests have all passed I am merging this to master and 1.5. Thanks @andrewor14 and @srowen . |
…ackpressure.{enable-->enabled} and fixed deprecated annotations
Small changes
- Renamed conf spark.streaming.backpressure.{enable --> enabled}
- Change Java Deprecated annotations to Scala deprecated annotation with more information.
Author: Tathagata Das <[email protected]>
Closes #8299 from tdas/SPARK-9967.
(cherry picked from commit bc9a0e0)
Signed-off-by: Tathagata Das <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea here was that this flag hadn't been 'released' yet so OK to change the name without keeping the old one?
The two changes in the PR were pretty unrelated right? still I can't imagine someone would really care about back-porting one and not be able to consume the other as they're minor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, for both. That's why went ahead with squashing both into one.
|
Test build #1664 timed out for PR 8299 at commit |
Small changes