[SPARK-10130] [SQL] type coercion for IF should have children resolved first #8331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Nit: Add a single line like "case e if !e.childrenResolved => e" will be enough?
Contributor
Author
There was a problem hiding this comment.
Sure, it's equivalent.
|
Test build #41307 has finished for PR 8331 at commit
|
adrian-wang
force-pushed
the
spark10130
branch
from
1921f34 to
e206797
Compare
|
Test build #41348 has finished for PR 8331 at commit
|
Contributor
Author
|
This is blocker issue and hopefully it is fixed in Spark 1.5.0, Thanks ! |
Contributor
|
Thanks, merging to master and 1.5 |
asfgit
pushed a commit
that referenced
this pull request
Aug 21, 2015
…d first Type coercion for IF should have children resolved first, or we could meet unresolved exception. Author: Daoyuan Wang <[email protected]> Closes #8331 from adrian-wang/spark10130. (cherry picked from commit 3c462f5) Signed-off-by: Michael Armbrust <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type coercion for IF should have children resolved first, or we could meet unresolved exception.