Skip to content

[SPARK-10188] [Pyspark] Pyspark CrossValidator with RMSE selects incorrect model #8399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
noel-smith wants to merge 6 commits into from
Closed

[SPARK-10188] [Pyspark] Pyspark CrossValidator with RMSE selects incorrect model #8399

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d00357e
Added test for cross validation
noel-smith Aug 24, 2015
6cd4ed1
Added/fixed tests for cross validation
noel-smith Aug 24, 2015
63b3835
Removed print statements
noel-smith Aug 24, 2015
7794cf7
Added checks for isLargerBetter()
noel-smith Aug 24, 2015
bada453
Added fixes from PR notes. Fixed style test failures.
noel-smith Aug 27, 2015
84c8a40
Style fix - missed a line of whitespace
noel-smith Aug 27, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Style fix - missed a line of whitespace
  • Loading branch information
@noel-smith
noel-smith committed Aug 27, 2015
commit 84c8a405e40d7428748e89819ba112bd87aa4869
2 changes: 1 addition & 1 deletion python/pyspark/ml/tuning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ def _fit(self, dataset):
# TODO: duplicate evaluator to take extra params from input
metric = eva.evaluate(model.transform(validation, epm[j]))
metrics[j] += metric

if eva.isLargerBetter():
bestIndex = np.argmax(metrics)
else:
Expand Down