Skip to content

[SPARK-10255][ML] Removes Guava dependencies from spark.ml.param JavaTests #8446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
feynmanliang wants to merge 1 commit into from
Closed

[SPARK-10255][ML] Removes Guava dependencies from spark.ml.param JavaTests #8446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions mllib/src/test/java/org/apache/spark/ml/param/JavaParamsSuite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@

package org.apache.spark.ml.param;

import com.google.common.collect.Lists;
import java.util.Arrays;

import org.junit.After;
import org.junit.Assert;
import org.junit.Before;
Expand Down Expand Up @@ -61,7 +62,7 @@ public void testParamValidate() {
ParamValidators.ltEq(1.0);
ParamValidators.inRange(0, 1, true, false);
ParamValidators.inRange(0, 1);
ParamValidators.inArray(Lists.newArrayList(0, 1, 3));
ParamValidators.inArray(Lists.newArrayList("a", "b"));
ParamValidators.inArray(Arrays.asList(0, 1, 3));
ParamValidators.inArray(Arrays.asList("a", "b"));
}
}
5 changes: 2 additions & 3 deletions mllib/src/test/java/org/apache/spark/ml/param/JavaTestParams.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,9 @@

package org.apache.spark.ml.param;

import java.util.Arrays;
import java.util.List;

import com.google.common.collect.Lists;

import org.apache.spark.ml.util.Identifiable$;

/**
Expand Down Expand Up @@ -89,7 +88,7 @@ private void init() {
myIntParam_ = new IntParam(this, "myIntParam", "this is an int param", ParamValidators.gt(0));
myDoubleParam_ = new DoubleParam(this, "myDoubleParam", "this is a double param",
ParamValidators.inRange(0.0, 1.0));
List<String> validStrings = Lists.newArrayList("a", "b");
List<String> validStrings = Arrays.asList("a", "b");
myStringParam_ = new Param<String>(this, "myStringParam", "this is a string param",
ParamValidators.inArray(validStrings));
myDoubleArrayParam_ =
Expand Down