Skip to content

SPARK-10220 org.apache.spark.sql.jdbc.JDBCRDD could not parse mysql t… #8448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fangfangchen-spark wants to merge 2 commits into from
Closed

SPARK-10220 org.apache.spark.sql.jdbc.JDBCRDD could not parse mysql t… #8448

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96b5f7e
SPARK-10220 org.apache.spark.sql.jdbc.JDBCRDD could not parse mysql t…
Aug 26, 2015
a4695a9
SPARK-10220 org.apache.spark.sql.jdbc.JDBCRDD could not parse mysql t…
Aug 26, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion sql/core/src/main/scala/org/apache/spark/sql/jdbc/JDBCRDD.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,11 @@ private[sql] class JDBCRDD(
if (sb.length == 0) "1" else sb.substring(1)
}

private val columnList_backquote: String = {
Copy link
Contributor

@andrewor14 andrewor14 Sep 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also in scala we use camel case instead of underscores.

val sb = new StringBuilder()
columns.foreach(x => sb.append(",").append("`" + x + "`"))
if (sb.length == 0) "1" else sb.substring(1)
}
/**
* Converts value to SQL expression.
*/
Expand Down Expand Up @@ -341,7 +346,7 @@ private[sql] class JDBCRDD(

val myWhereClause = getWhereClause(part)

val sqlText = s"SELECT $columnList FROM $fqTable $myWhereClause"
val sqlText = s"SELECT $columnList_backquote FROM $fqTable $myWhereClause"
val stmt = conn.prepareStatement(sqlText,
ResultSet.TYPE_FORWARD_ONLY, ResultSet.CONCUR_READ_ONLY)
val rs = stmt.executeQuery()
Expand Down