Skip to content

[SPARK-10323] [SQL] fix nullability of In/InSet/ArrayContain #8492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davies wants to merge 6 commits into from
Closed

[SPARK-10323] [SQL] fix nullability of In/InSet/ArrayContain #8492

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c3c65f8
fix nullability of In/InSet/ArrayContain
Aug 28, 2015
f8001e8
follow the nullability in PostgreSQL
Aug 28, 2015
3be8d05
fix test
Aug 28, 2015
5ca7823
remove test (don't make sense)
Aug 28, 2015
6887185
address comment
Aug 28, 2015
32ddc9f
address comments
Aug 28, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
address comments
  • Loading branch information
Davies Liu committed Aug 28, 2015
commit 32ddc9f5ee870a44b87ec88881402c96ef404d2c
4 changes: 4 additions & 0 deletions ...t/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionFunctionsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ class CollectionFunctionsSuite extends SparkFunSuite with ExpressionEvalHelper {
val a0 = Literal.create(Seq(1, 2, 3), ArrayType(IntegerType))
val a1 = Literal.create(Seq[String](null, ""), ArrayType(StringType))
val a2 = Literal.create(Seq(null), ArrayType(LongType))
val a3 = Literal.create(null, ArrayType(StringType))

checkEvaluation(ArrayContains(a0, Literal(1)), true)
checkEvaluation(ArrayContains(a0, Literal(0)), false)
Expand All @@ -81,5 +82,8 @@ class CollectionFunctionsSuite extends SparkFunSuite with ExpressionEvalHelper {

checkEvaluation(ArrayContains(a2, Literal(1L)), null)
checkEvaluation(ArrayContains(a2, Literal.create(null, LongType)), null)

checkEvaluation(ArrayContains(a3, Literal("")), null)
checkEvaluation(ArrayContains(a3, Literal.create(null, StringType)), null)
}
}
11 changes: 3 additions & 8 deletions ...atalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/ConstantFoldingSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,24 +250,19 @@ class ConstantFoldingSuite extends PlanTest {
}

test("Constant folding test: Fold In(v, list) into true or false") {
var originalQuery =
val originalQuery =
testRelation
.select('a)
.where(In(Literal(1), Seq(Literal(1), Literal(2))))

var optimized = Optimize.execute(originalQuery.analyze)
val optimized = Optimize.execute(originalQuery.analyze)

var correctAnswer =
val correctAnswer =
testRelation
.select('a)
.where(Literal(true))
.analyze

comparePlans(optimized, correctAnswer)

originalQuery =
testRelation
.select('a)
.where(In(Literal(1), Seq(Literal(1), 'a.attr)))
}
}