[SPARK-10325] Override hashCode() for public Row #8500
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
There's a disabled Scalastyle rule which would have prevented this problem. I'm going to see about re-enabling that rule and fixing the existing violations. |
|
Test build #41739 has finished for PR 8500 at commit
|
Contributor
|
Thanks, I'm going to merge this into master and 1.5 |
asfgit
pushed a commit
that referenced
this pull request
Aug 28, 2015
This commit fixes an issue where the public SQL `Row` class did not override `hashCode`, causing it to violate the hashCode() + equals() contract. To fix this, I simply ported the `hashCode` implementation from the 1.4.x version of `Row`. Author: Josh Rosen <[email protected]> Closes #8500 from JoshRosen/SPARK-10325 and squashes the following commits: 51ffea1 [Josh Rosen] Override hashCode() for public Row. (cherry picked from commit d3f87dc) Signed-off-by: Michael Armbrust <[email protected]> Conflicts: sql/catalyst/src/main/scala/org/apache/spark/sql/Row.scala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where the public SQL
Rowclass did not overridehashCode, causing it to violate the hashCode() + equals() contract. To fix this, I simply ported thehashCodeimplementation from the 1.4.x version ofRow.