Skip to content

[SPARK-10344][SQL] Add tests for extraStrategies #8516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
marmbrus wants to merge 1 commit into from
Closed

[SPARK-10344][SQL] Add tests for extraStrategies #8516

marmbrus wants to merge 1 commit into from

Conversation

@marmbrus
Copy link
Contributor

@marmbrus marmbrus commented Aug 29, 2015

Actually using this API requires access to a lot of classes that we might make private by accident. I've added some tests to prevent this.

@marmbrus marmbrus force-pushed the extraStrategiesTests branch from 696abba to 4a7c9ba Compare August 29, 2015 00:05
marmbrus
marmbrus reviewed Aug 29, 2015
View reviewed changes
sql/core/src/test/scala/org/apache/spark/sql/test/SharedSQLContext.scala
Copy link
Contributor Author

@marmbrus marmbrus Aug 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is already in the test jar... we we don't really ned to restrict visibility.

@SparkQA
Copy link

SparkQA commented Aug 29, 2015

Test build #41774 has finished for PR 8516 at commit 4a7c9ba.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class KMeans @Since("1.5.0") (

@yhuai
Copy link
Contributor

yhuai commented Aug 29, 2015

LGTM

asfgit pushed a commit that referenced this pull request Aug 29, 2015
@marmbrus @yhuai
[SPARK-10344] [SQL] Add tests for extraStrategies
a49ad67 
Actually using this API requires access to a lot of classes that we might make private by accident.  I've added some tests to prevent this.

Author: Michael Armbrust <[email protected]>

Closes #8516 from marmbrus/extraStrategiesTests.

(cherry picked from commit 5c3d16a)
Signed-off-by: Yin Huai <[email protected]>
@asfgit asfgit closed this in 5c3d16a Aug 29, 2015
@marmbrus marmbrus deleted the extraStrategiesTests branch March 8, 2016 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marmbrus @SparkQA @yhuai