[SPARK-10373] [PYSPARK] move @since into pyspark from sql #8657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #42152 has finished for PR 8657 at commit
|
Contributor
|
Would this also import the since function if somebody does "from pyspark import *"? |
Contributor
Author
|
@rxin No, it's not in |
Contributor
There was a problem hiding this comment.
Would it be OK to add a clause to handle situations where f.doc is None? There are a handful of methods without docstrings. Thanks!
Contributor
Author
There was a problem hiding this comment.
I think it's better to have some docs for public APIs.
Contributor
There was a problem hiding this comment.
You're right, that makes more sense. Ignore the comment above.
Contributor
|
LGTM. Merged into master. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @mengxr