Skip to content

[SPARK-10655][SQL] Adding additional data type mappings to jdbc DB2dialect. #9162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sureshthalamati wants to merge 3 commits into from
Closed

[SPARK-10655][SQL] Adding additional data type mappings to jdbc DB2dialect. #9162

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4abba5c
[SPARK-10655] Adding additional data type mappings to jdbc DB2Dialect.
sureshthalamati May 21, 2016
7eaaa30
Addressed review comments.
sureshthalamati May 25, 2016
8b8bc9a
Adding additional test cases for DECFLOAT(16) and DECFLOAT(34)
sureshthalamati Jun 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Addressed review comments.
  • Loading branch information
@sureshthalamati
sureshthalamati committed Jun 20, 2017
commit 7eaaa301de142c13198816c1e34ef2f9acf1e793
3 changes: 2 additions & 1 deletion sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -713,14 +713,15 @@ class JDBCSuite extends SparkFunSuite
val db2Dialect = JdbcDialects.get("jdbc:db2://127.0.0.1/db")
assert(db2Dialect.getJDBCType(StringType).map(_.databaseTypeDefinition).get == "CLOB")
assert(db2Dialect.getJDBCType(BooleanType).map(_.databaseTypeDefinition).get == "CHAR(1)")
assert(db2Dialect.getJDBCType(BooleanType).map(_.databaseTypeDefinition).get == "CHAR(1)")
assert(db2Dialect.getJDBCType(ShortType).map(_.databaseTypeDefinition).get == "SMALLINT")
assert(db2Dialect.getJDBCType(ByteType).map(_.databaseTypeDefinition).get == "SMALLINT")
// test db2 dialect mappings on read
assert(db2Dialect.getCatalystType(java.sql.Types.REAL, "REAL", 1, null) == Option(FloatType))
assert(db2Dialect.getCatalystType(java.sql.Types.OTHER, "DECFLOAT", 1, null) ==
Option(DecimalType(38, 18)))
assert(db2Dialect.getCatalystType(java.sql.Types.OTHER, "XML", 1, null) == Option(StringType))
assert(db2Dialect.getCatalystType(java.sql.Types.OTHER, "TIMESTAMP WITH TIME ZONE", 1, null) ==
Option(TimestampType))
}

test("PostgresDialect type mapping") {
Expand Down