Skip to content

SPARK-6541 - Sort executors by ID (numeric) #9165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jbonofre wants to merge 6 commits into from
Closed

SPARK-6541 - Sort executors by ID (numeric) #9165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f7bbd4d
SPARK-6541 - Sort executor by id
jbonofre Nov 8, 2015
4446ffd
SPARK-6541 - Cleanup indentation and style
jbonofre Nov 10, 2015
d6154d9
SPARK-6541 - Cleanup indentation in sorttable.js
jbonofre Nov 10, 2015
078e438
Avoid unintended change in sorttable.js
jbonofre Nov 17, 2015
04cb4ce
SPARK-6541 - Avoid unintended changes in sorttable.js
jbonofre Nov 17, 2015
f6c5f3f
SPARK-6541 - Cleanup sorttable.js
jbonofre Nov 17, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/resources/org/apache/spark/ui/static/sorttable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ sorttable = {
// make it clickable to sort
headrow[i].sorttable_columnindex = i;
headrow[i].sorttable_tbody = table.tBodies[0];
dean_addEvent(headrow[i],"click", function(e) {
dean_addEvent(headrow[i],"click", sorttable.innerSortFunction = function(e) {

if (this.className.search(/\bsorttable_sorted\b/) != -1) {
// if we're already sorted by this column, just
Expand Down
13 changes: 11 additions & 2 deletions core/src/main/scala/org/apache/spark/ui/jobs/ExecutorTable.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
package org.apache.spark.ui.jobs

import scala.collection.mutable
import scala.xml.Node
import scala.xml.{Unparsed, Node}

import org.apache.spark.ui.{ToolTips, UIUtils}
import org.apache.spark.ui.jobs.UIData.StageUIData
Expand Down Expand Up @@ -52,7 +52,7 @@ private[ui] class ExecutorTable(stageId: Int, stageAttemptId: Int, parent: Stage

<table class={UIUtils.TABLE_CLASS_STRIPED_SORTABLE}>
<thead>
<th>Executor ID</th>
<th id="executorid">Executor ID</th>
<th>Address</th>
<th>Task Time</th>
<th>Total Tasks</th>
Expand Down Expand Up @@ -89,6 +89,15 @@ private[ui] class ExecutorTable(stageId: Int, stageAttemptId: Int, parent: Stage
{createExecutorTable()}
</tbody>
</table>
<script>
{Unparsed {
"""
| window.onload = function() {
| sorttable.innerSortFunction.apply(document.getElementById('executorid'), [])
| };
""".stripMargin
}}
</script>
}

private def createExecutorTable() : Seq[Node] = {
Expand Down