Skip to content

[SPARK-11207][ML] Add test cases for solver selection of LinearRegres… #9180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Lewuathe wants to merge 14 commits into from
Closed

[SPARK-11207][ML] Add test cases for solver selection of LinearRegres… #9180

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
11cd9c1
[SPARK-11207][ML] Add test cases for solver selection of LinearRegres…
Lewuathe Oct 20, 2015
28427d2
Fix scalastyle
Lewuathe Oct 20, 2015
f85bca6
[SPARK-11207] Improve test case with many feature datasets
Lewuathe Oct 21, 2015
22ba64e
Merge branch 'master' into SPARK-11207
Lewuathe Oct 21, 2015
f6b2256
[SPARK-11207] Remove extra lines
Lewuathe Oct 22, 2015
2082d47
[SPARK-11207] Pass sparcity to generateLinearSparseInput
Lewuathe Oct 24, 2015
003d3bd
[SPARK-11207] Add new API for generateLinearInput
Lewuathe Oct 24, 2015
0a43033
[SPARK-11207] Fix tests
Lewuathe Oct 25, 2015
59383fd
[SPARK-11207] Fix random values used by unit tests
Lewuathe Oct 25, 2015
888b216
Update Fri Oct 30 15:39:05 JST 2015
Lewuathe Oct 30, 2015
c27a4c3
Resolv conflict
Lewuathe Oct 30, 2015
97c76c9
Merge branch 'master' into SPARK-11207
Lewuathe Oct 30, 2015
74de81e
Fix style
Lewuathe Oct 30, 2015
241ec72
Minor fixed
Lewuathe Oct 30, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[SPARK-11207] Fix random values used by unit tests
  • Loading branch information
@Lewuathe
Lewuathe committed Oct 25, 2015
commit 59383fd41f1d6b96274c564eb2fb7c96f5ab07e0
3 changes: 2 additions & 1 deletion mllib/src/main/scala/org/apache/spark/mllib/util/LinearDataGenerator.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,9 @@ object LinearDataGenerator {
x.foreach { v =>
Copy link
Member

@dbtsai dbtsai Oct 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you have sparsity, randomly choose n = numFeatures * (1 - sparsity) as non-zero features, and zero the rest out.

Copy link
Member

@dbtsai dbtsai Oct 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also add the variance of sparsity such that the num of non zeros will not be constant.

var i = 0
val len = v.length
val sparceRnd = new Random(seed)
Copy link
Member

@dbtsai dbtsai Oct 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you seed rnd and sparceRnd with the same seed, both of them will generate the same sequence of random numbers which is not what you want. You should be able to use the same random number generator which will give you uncorrelated random numbers in both creating the features and choice which columns to zero out.

Copy link
Contributor Author

@Lewuathe Lewuathe Oct 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we use same random generator for both creating features and choice which columns to zero, x is different from current ones. This cause unit test failures. Can we change the assertion tolerance or target written in LinearRegressionSuite?

while (i < len) {
if (rnd.nextDouble() <= sparcity) {
if (sparceRnd.nextDouble() < sparcity) {
v(i) = 0.0
} else {
v(i) = (v(i) - 0.5) * math.sqrt(12.0 * xVariance(i)) + xMean(i)
Expand Down