Skip to content

[SPARK-8658] [SQL] AttributeReference's equals method compares all the members #9216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gatorsmile wants to merge 6 commits into from
Closed

[SPARK-8658] [SQL] AttributeReference's equals method compares all the members #9216

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
029b5ba
Spark-8658
gatorsmile Oct 22, 2015
4425dbc
replace equal by semanticEquals
gatorsmile Nov 13, 2015
01e4cdf
Merge remote-tracking branch 'upstream/master'
gatorsmile Nov 13, 2015
8e72b17
merge the latest master
gatorsmile Nov 14, 2015
4590af1
replace equal by semanticEquals
gatorsmile Nov 14, 2015
5decf82
style change
gatorsmile Nov 14, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
style change
  • Loading branch information
@gatorsmile
gatorsmile committed Nov 14, 2015
commit 5decf82631dbeb3c05cc86965627760e60615da5
4 changes: 2 additions & 2 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ case class HashPartitioning(expressions: Seq[Expression], numPartitions: Int)
override def satisfies(required: Distribution): Boolean = required match {
case UnspecifiedDistribution => true
case ClusteredDistribution(requiredClustering) =>
expressions.forall(x=>requiredClustering.exists(_.semanticEquals(x)))
expressions.forall(x => requiredClustering.exists(_.semanticEquals(x)))
case _ => false
}

Expand Down Expand Up @@ -276,7 +276,7 @@ case class RangePartitioning(ordering: Seq[SortOrder], numPartitions: Int)
val minSize = Seq(requiredOrdering.size, ordering.size).min
requiredOrdering.take(minSize) == ordering.take(minSize)
case ClusteredDistribution(requiredClustering) =>
ordering.map(_.child).forall(x=>requiredClustering.exists(_.semanticEquals(x)))
ordering.map(_.child).forall(x => requiredClustering.exists(_.semanticEquals(x)))
case _ => false
}

Expand Down