Skip to content

[SPARK-11322][PySpark] Keep full stack trace in captured exception #9283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
viirya wants to merge 9 commits into from
Closed

[SPARK-11322][PySpark] Keep full stack trace in captured exception #9283

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0ccb4ae
Keep full stack trace in captured exception.
viirya Oct 26, 2015
3769f01
Add custom exception class.
viirya Oct 27, 2015
18c1695
Fix python style.
viirya Oct 27, 2015
8f69480
Fix it.
viirya Oct 27, 2015
8e5d5d8
Merge remote-tracking branch 'upstream/master' into py-exception-stac…
viirya Oct 28, 2015
11d6f09
Make it looks like a Java stacktrace.
viirya Oct 28, 2015
f4cae6c
Fix python style.
viirya Oct 28, 2015
8d48e13
Add a space.
viirya Oct 28, 2015
8535f06
Fix python style.
viirya Oct 28, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Keep full stack trace in captured exception.
  • Loading branch information
@viirya
viirya committed Oct 26, 2015
commit 0ccb4ae38b797c10dfea45d762932bb07d1d9d53
6 changes: 6 additions & 0 deletions python/pyspark/sql/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1079,6 +1079,12 @@ def test_capture_illegalargument_exception(self):
df = self.sqlCtx.createDataFrame([(1, 2)], ["a", "b"])
self.assertRaisesRegexp(IllegalArgumentException, "1024 is not in the permitted values",
lambda: df.select(sha2(df.a, 1024)).collect())
try:
df.select(sha2(df.a, 1024)).collect()
except IllegalArgumentException as e:
self.assertRegexpMatches(e.args[0], "1024 is not in the permitted values")
self.assertRegexpMatches(e.args[1],
"org.apache.spark.sql.functions")

def test_with_column_with_existing_name(self):
keys = self.df.withColumn("key", self.df.key).select("key").collect()
Expand Down
5 changes: 3 additions & 2 deletions python/pyspark/sql/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,11 @@ def deco(*a, **kw):
return f(*a, **kw)
except py4j.protocol.Py4JJavaError as e:
s = e.java_exception.toString()
stackTrace = '\n'.join(map(lambda x: x.toString(), e.java_exception.getStackTrace()))
Copy link
Contributor

@davies davies Oct 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'\n\t at ', make it looks like a Java stacktrace

if s.startswith('org.apache.spark.sql.AnalysisException: '):
raise AnalysisException(s.split(': ', 1)[1])
raise AnalysisException(s.split(': ', 1)[1], stackTrace)
if s.startswith('java.lang.IllegalArgumentException: '):
raise IllegalArgumentException(s.split(': ', 1)[1])
raise IllegalArgumentException(s.split(': ', 1)[1], stackTrace)
raise
return deco

Expand Down