Skip to content

Conversation

@gliptak
Copy link
Contributor

@gliptak gliptak commented Oct 30, 2015

…ude_example

@mengxr
Copy link
Contributor

mengxr commented Oct 30, 2015

@yinxusen Could you help review?

@gliptak
Copy link
Contributor Author

gliptak commented Oct 31, 2015

@mengxr Could you trigger a build (including site?)? Thanks

@yinxusen
Copy link
Contributor

yinxusen commented Nov 1, 2015

@mengxr Yes I will review it.

@yinxusen
Copy link
Contributor

yinxusen commented Nov 1, 2015

@gliptak Why the code changes do not match with the title? I think the SPARK-11382 should fix mllib-decision-tree.md and mllib-ensembles.md.

@gliptak
Copy link
Contributor Author

gliptak commented Nov 1, 2015

I was planning to split into two commits (although I'm open to work the other file in this same commit). Thanks

@yinxusen
Copy link
Contributor

yinxusen commented Nov 2, 2015

@gliptak I mean, this JIRA issue aiming to modify decision-tree.md and mllib-ensembles.md, but your pull request changes mllib-frequent-pattern-mining.md.

@gliptak
Copy link
Contributor Author

gliptak commented Nov 2, 2015

Can I add new JIRA covering mllib-ensembles.md?

@yinxusen
Copy link
Contributor

yinxusen commented Nov 2, 2015

Yes you can.

@gliptak
Copy link
Contributor Author

gliptak commented Nov 2, 2015

@mengxr
Copy link
Contributor

mengxr commented Nov 4, 2015

ok to test

@SparkQA
Copy link

SparkQA commented Nov 4, 2015

Test build #45023 has finished for PR 9378 at commit 7bcdee5.

  • This patch fails Scala style tests.
  • This patch does not merge cleanly.
  • This patch adds the following public classes (experimental):\n * public class JavaAssociationRulesExample\n * public class JavaPrefixSpanExample\n

@gliptak
Copy link
Contributor Author

gliptak commented Nov 5, 2015

This became a duplicate of #9340

commit 820064e
Author: Pravin Gadakh [email protected]
Date: Wed Nov 4 08:32:08 2015 -0800

[SPARK-11380][DOCS] Replace example code in mllib-frequent-pattern-mining.md using include_example

Author: Pravin Gadakh <[email protected]>
Author: Pravin Gadakh <[email protected]>

Closes #9340 from pravingadakh/SPARK-11380.

@gliptak gliptak closed this Nov 5, 2015
@yinxusen
Copy link
Contributor

yinxusen commented Nov 6, 2015

@gliptak Yes it is duplicated with #9340 . Do you plan to change example code of mllib decision tree?

@yinxusen
Copy link
Contributor

yinxusen commented Nov 6, 2015

@gliptak And sorry for my mistake of the mismatch between the title and content in SPARK-11382. I have already corrected its content.

@gliptak
Copy link
Contributor Author

gliptak commented Nov 6, 2015

https://issues.apache.org/jira/browse/SPARK-11445 is already being worked at #9407

@yinxusen
Copy link
Contributor

yinxusen commented Nov 6, 2015

@gliptak, SPARK-11445 aims to fix mllib-ensemble.md, while this one (SPARK-11382) aims to fix mllib-decision-tree.md. They are two different JIRA issues.

@gliptak
Copy link
Contributor Author

gliptak commented Nov 6, 2015

@yinxusen

Now I'm confused myself. Current master already have mllib-frequent-pattern-mining.md corrected:

https://raw.githubusercontent.com/apache/spark/master/docs/mllib-frequent-pattern-mining.md

so this pull request was superceded (although the title doesn't match changes in my branch).

Please confirm that I see this correctly.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants