-
Notifications
You must be signed in to change notification settings - Fork 29k
SPARK-11382 Replace example code in mllib-decision-tree.md using incl… #9378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@yinxusen Could you help review? |
|
@mengxr Could you trigger a build (including site?)? Thanks |
|
@mengxr Yes I will review it. |
|
@gliptak Why the code changes do not match with the title? I think the SPARK-11382 should fix mllib-decision-tree.md and mllib-ensembles.md. |
|
I was planning to split into two commits (although I'm open to work the other file in this same commit). Thanks |
|
@gliptak I mean, this JIRA issue aiming to modify decision-tree.md and mllib-ensembles.md, but your pull request changes mllib-frequent-pattern-mining.md. |
|
Can I add new JIRA covering mllib-ensembles.md? |
|
Yes you can. |
|
Created https://issues.apache.org/jira/browse/SPARK-11445 and updated description of https://issues.apache.org/jira/browse/SPARK-11382 |
|
ok to test |
|
Test build #45023 has finished for PR 9378 at commit
|
|
This became a duplicate of #9340 commit 820064e |
|
@gliptak And sorry for my mistake of the mismatch between the title and content in SPARK-11382. I have already corrected its content. |
|
https://issues.apache.org/jira/browse/SPARK-11445 is already being worked at #9407 |
|
@gliptak, SPARK-11445 aims to fix mllib-ensemble.md, while this one (SPARK-11382) aims to fix mllib-decision-tree.md. They are two different JIRA issues. |
|
Now I'm confused myself. Current master already have mllib-frequent-pattern-mining.md corrected: https://raw.githubusercontent.com/apache/spark/master/docs/mllib-frequent-pattern-mining.md so this pull request was superceded (although the title doesn't match changes in my branch). Please confirm that I see this correctly. Thanks |
…ude_example