[SPARK-9858] [SQL] Add an ExchangeCoordinator to estimate the number of post-shuffle partitions for aggregates and joins (follow-up) #9453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @JoshRosen |
|
Test build #44970 has finished for PR 9453 at commit
|
Contributor
Author
There was a problem hiding this comment.
@nongli Can you take a look at here? If one side of the join is shuffled, I am trying to avoid of shuffling that side.
Contributor
There was a problem hiding this comment.
Looks good to me. Can you update/remove the TODO on line 419?
|
Test build #45066 has finished for PR 9453 at commit
|
Contributor
There was a problem hiding this comment.
Nit. Even if two input RDDs have different number of ...
|
Test build #45197 has finished for PR 9453 at commit
|
Contributor
|
looks good to me |
Contributor
Author
|
Thanks for reviewing! I am merging it to master and branch 1.6. |
asfgit
pushed a commit
that referenced
this pull request
Nov 6, 2015
…f post-shuffle partitions for aggregates and joins (follow-up) https://issues.apache.org/jira/browse/SPARK-9858 This PR is the follow-up work of #9276. It addresses JoshRosen's comments. Author: Yin Huai <[email protected]> Closes #9453 from yhuai/numReducer-followUp. (cherry picked from commit 8211aab) Signed-off-by: Yin Huai <[email protected]>
markhamstra
pushed a commit
to markhamstra/spark
that referenced
this pull request
Nov 11, 2015
…f post-shuffle partitions for aggregates and joins (follow-up) https://issues.apache.org/jira/browse/SPARK-9858 This PR is the follow-up work of apache#9276. It addresses JoshRosen's comments. Author: Yin Huai <[email protected]> Closes apache#9453 from yhuai/numReducer-followUp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SPARK-9858
This PR is the follow-up work of #9276. It addresses @JoshRosen's comments.