-
Notifications
You must be signed in to change notification settings - Fork 29k
SPARK-11112 Fix Scala 2.11 compilation error in RDDInfo.scala #9538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CC @andrewor14 / 7f74190 |
|
It worked fine for me. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a reasonable way to address the compilation failure, but I think this is also changing the API in a binary-incompatible way? MiMa will tell us. If so then actually we will need the new constructor to not take a final optional arg. Or, adjust callers to not actually need the optional arg and use the existing constructor, passing empty if needed.
|
Test build #45283 has finished for PR 9538 at commit
|
|
MiMA check passed. |
|
@andrewor14 does that seem OK to you? Looks like the PR went only to master so this needs to go to master? |
|
Knock, knock. Can we do someting with the patch as the build procedure for Scala 2.11 expanded with another step - |
|
Ping @andrewor14 |
|
Hi sorry I've been out for vacation I will have a look at this now. |
|
Merging into master 1.6 |
As shown in https://amplab.cs.berkeley.edu/jenkins/view/Spark-QA-Compile/job/Spark-Master-Scala211-Compile/1946/console , compilation fails with: ``` [error] /home/jenkins/workspace/Spark-Master-Scala211-Compile/core/src/main/scala/org/apache/spark/storage/RDDInfo.scala:25: in class RDDInfo, multiple overloaded alternatives of constructor RDDInfo define default arguments. [error] class RDDInfo( [error] ``` This PR tries to fix the compilation error Author: tedyu <[email protected]> Closes #9538 from tedyu/master. (cherry picked from commit 404a28f) Signed-off-by: Andrew Or <[email protected]>
As shown in https://amplab.cs.berkeley.edu/jenkins/view/Spark-QA-Compile/job/Spark-Master-Scala211-Compile/1946/console , compilation fails with:
This PR tries to fix the compilation error