Skip to content

Conversation

@tedyu
Copy link
Contributor

@tedyu tedyu commented Nov 7, 2015

As shown in https://amplab.cs.berkeley.edu/jenkins/view/Spark-QA-Compile/job/Spark-Master-Scala211-Compile/1946/console , compilation fails with:

[error] /home/jenkins/workspace/Spark-Master-Scala211-Compile/core/src/main/scala/org/apache/spark/storage/RDDInfo.scala:25: in class RDDInfo, multiple overloaded alternatives of constructor RDDInfo define default arguments.
[error] class RDDInfo(
[error]       

This PR tries to fix the compilation error

@srowen
Copy link
Member

srowen commented Nov 7, 2015

CC @andrewor14 / 7f74190
@tedyu you should probably attach this to SPARK-11112

@jaceklaskowski
Copy link
Contributor

It worked fine for me.

➜  spark git:(master) ✗ ./build/mvn -Pyarn -Phadoop-2.6 -Dhadoop.version=2.7.1 -Dscala-2.11 -Phive -Phive-thriftserver -DskipTests clean install
...
[INFO] BUILD SUCCESS

Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a reasonable way to address the compilation failure, but I think this is also changing the API in a binary-incompatible way? MiMa will tell us. If so then actually we will need the new constructor to not take a final optional arg. Or, adjust callers to not actually need the optional arg and use the existing constructor, passing empty if needed.

@SparkQA
Copy link

SparkQA commented Nov 7, 2015

Test build #45283 has finished for PR 9538 at commit bfaf2d5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * class ExecutionMemoryPool(\n * abstract class MemoryPool(lock: Object)\n * class StorageMemoryPool(lock: Object) extends MemoryPool(lock) with Logging\n * class LDAModel(JavaModelWrapper, JavaSaveable, Loader):\n

@tedyu
Copy link
Contributor Author

tedyu commented Nov 7, 2015

MiMA check passed.

@tedyu tedyu changed the title Fix Scala 2.11 compilation error in RDDInfo.scala SPARK-11112 Fix Scala 2.11 compilation error in RDDInfo.scala Nov 7, 2015
@srowen
Copy link
Member

srowen commented Nov 8, 2015

@andrewor14 does that seem OK to you? Looks like the PR went only to master so this needs to go to master?

@jaceklaskowski
Copy link
Contributor

Knock, knock. Can we do someting with the patch as the build procedure for Scala 2.11 expanded with another step - git merge pr-9538 beside ./dev/change-scala-version.sh 2.11 and ./build/mvn -Pyarn -Phadoop-2.6 -Dhadoop.version=2.7.1 -Dscala-2.11 -Phive -Phive-thriftserver -DskipTests clean install :(

@tedyu
Copy link
Contributor Author

tedyu commented Nov 9, 2015

Ping @andrewor14

@andrewor14
Copy link
Contributor

Hi sorry I've been out for vacation I will have a look at this now.

@andrewor14
Copy link
Contributor

Merging into master 1.6

asfgit pushed a commit that referenced this pull request Nov 9, 2015
As shown in https://amplab.cs.berkeley.edu/jenkins/view/Spark-QA-Compile/job/Spark-Master-Scala211-Compile/1946/console , compilation fails with:
```
[error] /home/jenkins/workspace/Spark-Master-Scala211-Compile/core/src/main/scala/org/apache/spark/storage/RDDInfo.scala:25: in class RDDInfo, multiple overloaded alternatives of constructor RDDInfo define default arguments.
[error] class RDDInfo(
[error]
```
This PR tries to fix the compilation error

Author: tedyu <[email protected]>

Closes #9538 from tedyu/master.

(cherry picked from commit 404a28f)
Signed-off-by: Andrew Or <[email protected]>
@asfgit asfgit closed this in 404a28f Nov 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants