[SPARK-11599] [SQL] fix NPE when resolve Hive UDF in SQLParser #9576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Just a note. In HiveQLDialect, when we parse a query, we use sqlContext.executionHive.withHiveState. Right now, create function is still broken because the metadata of the function is in metadata hive. However, it is the work of another PR.
Contributor
|
LGTM pending jenkins. |
|
Test build #45427 has finished for PR 9576 at commit
|
|
Test build #2023 has finished for PR 9576 at commit
|
Contributor
Author
|
Merged into master and 1.6. |
asfgit
pushed a commit
that referenced
this pull request
Nov 10, 2015
The DataFrame APIs that takes a SQL expression always use SQLParser, then the HiveFunctionRegistry will called outside of Hive state, cause NPE if there is not a active Session State for current thread (in PySpark). cc rxin yhuai Author: Davies Liu <[email protected]> Closes #9576 from davies/hive_udf. (cherry picked from commit d6cd3a1) Signed-off-by: Davies Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DataFrame APIs that takes a SQL expression always use SQLParser, then the HiveFunctionRegistry will called outside of Hive state, cause NPE if there is not a active Session State for current thread (in PySpark).
cc @rxin @yhuai