Skip to content

[SPARK-8029] Robust shuffle writer #9610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davies wants to merge 8 commits into from
Closed

[SPARK-8029] Robust shuffle writer #9610

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b2a90c6
use temporary file and rename to avoid concurrent write
Nov 10, 2015
9f0d2f9
fix tests
Nov 11, 2015
55485a9
address comments
Nov 11, 2015
6deccff
fix test
Nov 11, 2015
f0c2a5d
address comments
Nov 12, 2015
d0b937f
rename
Nov 12, 2015
35bd469
add regression test
Nov 13, 2015
71b12bf
address comments
Nov 13, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix test
  • Loading branch information
Davies Liu committed Nov 11, 2015
commit 6deccff9d322b92538a470329581c8abeb8f7e6a
11 changes: 11 additions & 0 deletions core/src/test/scala/org/apache/spark/shuffle/sort/BypassMergeSortShuffleWriterSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,17 @@ class BypassMergeSortShuffleWriterSuite extends SparkFunSuite with BeforeAndAfte
when(dependency.serializer).thenReturn(Some(new JavaSerializer(conf)))
when(taskContext.taskMetrics()).thenReturn(taskMetrics)
when(blockResolver.getDataFile(0, 0)).thenReturn(outputFile)
doAnswer(new Answer[Void] {
def answer(invocationOnMock: InvocationOnMock): Void = {
val tmp: File = invocationOnMock.getArguments()(3).asInstanceOf[File]
if (tmp != null) {
outputFile.delete
tmp.renameTo(outputFile)
}
null
}
}).when(blockResolver)
.writeIndexFile(anyInt, anyInt, any(classOf[Array[Long]]), any(classOf[File]))
when(blockManager.diskBlockManager).thenReturn(diskBlockManager)
when(blockManager.getDiskWriter(
any[BlockId],
Expand Down