Skip to content

Conversation

@andrewor14
Copy link
Contributor

No description provided.

@andrewor14
Copy link
Contributor Author

@tnachen please verify whether the mesos part is correct.

@SparkQA
Copy link

SparkQA commented Nov 11, 2015

Test build #45674 has finished for PR 9637 at commit 48d7418.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to add that users can run the mesos-shuffle-service.sh with Marathon, and they should start the service in the foreground running spark-class org.apache.spark.deploy.mesos.MesosExternalShuffleService

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what you mean about the latter part. If you wish you can submit a patch against the same issue to augment the description here.

@tnachen
Copy link
Contributor

tnachen commented Nov 11, 2015

Only have one comment, otherwise everything else LGTM

@SparkQA
Copy link

SparkQA commented Nov 12, 2015

Test build #45767 has finished for PR 9637 at commit 8200bf5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@tnachen
Copy link
Contributor

tnachen commented Nov 12, 2015

I think this is fine for now, I was thinking leaving some comments about how it should be launched with Marathon but I think later we can add a example json in the Marathon repo that we can link from here.

@tnachen
Copy link
Contributor

tnachen commented Nov 12, 2015

LGTM

@andrewor14
Copy link
Contributor Author

Thanks Tim, merging into master 1.6.

asfgit pushed a commit that referenced this pull request Nov 12, 2015
…ster managers

Author: Andrew Or <[email protected]>

Closes #9637 from andrewor14/update-da-docs.

(cherry picked from commit 12a0784)
Signed-off-by: Andrew Or <[email protected]>
@asfgit asfgit closed this in 12a0784 Nov 12, 2015
@andrewor14 andrewor14 deleted the update-da-docs branch November 12, 2015 23:52
dskrvk pushed a commit to dskrvk/spark that referenced this pull request Nov 13, 2015
…ster managers

Author: Andrew Or <[email protected]>

Closes apache#9637 from andrewor14/update-da-docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants