Skip to content

[SPARK-11712] [ML] Make spark.ml LDAModel be abstract #9678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jkbradley wants to merge 5 commits into from
Closed

[SPARK-11712] [ML] Make spark.ml LDAModel be abstract #9678

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2545c89
partial implementation, but hit issue with lazy val
jkbradley Nov 11, 2015
3c97e41
refactored spark.ml LDAModel to be abstract
jkbradley Nov 12, 2015
9f39384
doc fix
jkbradley Nov 12, 2015
29d08a8
updated test suite
jkbradley Nov 12, 2015
b3e9341
minor updates per code review
jkbradley Nov 12, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
updated test suite
  • Loading branch information
@jkbradley
jkbradley committed Nov 12, 2015
commit 29d08a8c2c07ceae88dab1f3abef575ef5b5322c
4 changes: 2 additions & 2 deletions mllib/src/test/scala/org/apache/spark/ml/clustering/LDASuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ class LDASuite extends SparkFunSuite with MLlibTestSparkContext {

MLTestingUtils.checkCopy(model)

assert(!model.isInstanceOf[DistributedLDAModel])
assert(model.isInstanceOf[LocalLDAModel])
assert(model.vocabSize === vocabSize)
assert(model.estimatedDocConcentration.size === k)
assert(model.topicsMatrix.numRows === vocabSize)
Expand Down Expand Up @@ -210,7 +210,7 @@ class LDASuite extends SparkFunSuite with MLlibTestSparkContext {
assert(model.isDistributed)

val localModel = model.toLocal
assert(!localModel.isInstanceOf[DistributedLDAModel])
assert(localModel.isInstanceOf[LocalLDAModel])

// training logLikelihood, logPrior
val ll = model.trainingLogLikelihood
Expand Down