Skip to content

Conversation

@vikasnp
Copy link

@vikasnp vikasnp commented Nov 13, 2015

No description provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd better making these class names more concretely. I.e. JavaBinaryClassificatinMetricsExample. And the same for the following classes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a space line

@vikasnp
Copy link
Author

vikasnp commented Nov 19, 2015

@yinxusen Thanks for patiently pointing out the issues. I've fixed them. Please test it.

@SparkQA
Copy link

SparkQA commented Nov 19, 2015

Test build #46322 has finished for PR 9689 at commit 1c5cc8f.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * public class JavaBinaryClassificationMetricsExample\n * public class JavaMultiLabelClassificationMetricsExample\n * public class JavaMulticlassClassificationMetricsExample\n * SparkConf conf = new SparkConf().setAppName(\"Multi class Classification Metrics Example\");\n * public class JavaRankingMetricsExample\n * public class JavaRegressionMetricsExample\n

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove it, there are two $example on$

@yinxusen
Copy link
Contributor

@mengxr LGTM except for some minor issues.

@vikasnp
Copy link
Author

vikasnp commented Nov 19, 2015

@yinxusen @mengxr Style tests passed this time. I've removed those extra lines

@SparkQA
Copy link

SparkQA commented Nov 19, 2015

Test build #46324 has finished for PR 9689 at commit 88512e7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * public class JavaBinaryClassificationMetricsExample\n * public class JavaMultiLabelClassificationMetricsExample\n * public class JavaMulticlassClassificationMetricsExample\n * SparkConf conf = new SparkConf().setAppName(\"Multi class Classification Metrics Example\");\n * public class JavaRankingMetricsExample\n * public class JavaRegressionMetricsExample\n

@vikasnp
Copy link
Author

vikasnp commented Nov 19, 2015

@yinxusen @mengxr Can we merge this, if there aren't any further issues?

asfgit pushed a commit that referenced this pull request Nov 20, 2015
…md using include_example

Author: Vikas Nelamangala <[email protected]>

Closes #9689 from vikasnp/master.

(cherry picked from commit ed47b1e)
Signed-off-by: Xiangrui Meng <[email protected]>
@mengxr
Copy link
Contributor

mengxr commented Nov 20, 2015

Merged into master and branch-1.6. Thanks!

@asfgit asfgit closed this in ed47b1e Nov 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants