[SPARK-11281][SPARKR] Add tests covering the issue. #9743
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Jenkins, ok to test |
|
Test build #46017 has finished for PR 9743 at commit
|
R/pkg/inst/tests/test_sparkSQL.R
Outdated
Contributor
There was a problem hiding this comment.
how about
expect_identical(ldf[, 1], collected[, 1])?
zero323
force-pushed
the
SPARK-11281-tests
branch
from
7c2cb03 to
0508988
Compare
|
Test build #46089 has finished for PR 9743 at commit
|
R/pkg/inst/tests/test_sparkSQL.R
Outdated
Contributor
There was a problem hiding this comment.
style: a = 1, b = 2; c = 3
Contributor
|
LGTM except a minor comment on coding style |
zero323
force-pushed
the
SPARK-11281-tests
branch
from
0508988 to
6d2be57
Compare
|
Test build #46201 has finished for PR 9743 at commit
|
zero323
force-pushed
the
SPARK-11281-tests
branch
from
6d2be57 to
c7ff1f2
Compare
|
Test build #46212 has finished for PR 9743 at commit
|
Contributor
asfgit
pushed a commit
that referenced
this pull request
Nov 18, 2015
The goal of this PR is to add tests covering the issue to ensure that is was resolved by [SPARK-11086](https://issues.apache.org/jira/browse/SPARK-11086). Author: zero323 <[email protected]> Closes #9743 from zero323/SPARK-11281-tests. (cherry picked from commit a97d6f3) Signed-off-by: Shivaram Venkataraman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to add tests covering the issue to ensure that is was resolved by SPARK-11086.