Skip to content

Conversation

@mengxr
Copy link
Contributor

@mengxr mengxr commented Nov 17, 2015

This PR makes the default read/write work with simple transformers/estimators that have params of type Param[Vector]. @jkbradley

@jkbradley
Copy link
Member

Unrelated failure.

This LGTM.

My only comment is that the implementation assumes we won't add many Param types support by the default jsonEncode. That seems reasonable. (If we wanted to support more in the future, we might want a designated type field to specify the type being loaded.)

@mengxr
Copy link
Contributor Author

mengxr commented Nov 17, 2015

We overrided jsonEncode/jsonDecode for basic param types. This could be simpler if we added class tags or associate schema with the parameters.

@SparkQA
Copy link

SparkQA commented Nov 17, 2015

Test build #2082 has finished for PR 9776 at commit 4ac3d7e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * case class ArrayConversion(elementConversion: JDBCConversion) extends JDBCConversion\n * abstract class JdbcDialect extends Serializable\n

@asfgit asfgit closed this in 3e9e638 Nov 17, 2015
asfgit pushed a commit that referenced this pull request Nov 17, 2015
This PR makes the default read/write work with simple transformers/estimators that have params of type `Param[Vector]`. jkbradley

Author: Xiangrui Meng <[email protected]>

Closes #9776 from mengxr/SPARK-11764.

(cherry picked from commit 3e9e638)
Signed-off-by: Xiangrui Meng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants