Skip to content

[SPARK-11339][SPARKR] Document the list of functions in R base package that are masked by functions with same name in SparkR #9785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
felixcheung wants to merge 10 commits into from
Closed

[SPARK-11339][SPARKR] Document the list of functions in R base package that are masked by functions with same name in SparkR #9785

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0aa9ca7
Add masked method tests for table, sample, lag, summary
felixcheung Nov 14, 2015
7bbaf7b
Add tests for bind, intersect, cov
felixcheung Nov 14, 2015
4bb3b66
Add test for subset, filter, na.omit
felixcheung Nov 14, 2015
5071af9
update tests
felixcheung Nov 15, 2015
c598a6d
doc update
felixcheung Nov 18, 2015
7311cb5
fix lag and subset
felixcheung Nov 18, 2015
2d81394
fix filter
felixcheung Nov 18, 2015
70c806a
revert filter, add test for predict
felixcheung Nov 19, 2015
dd3f83c
fix busted test
felixcheung Nov 19, 2015
71f3be7
disable filter test
felixcheung Nov 19, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test for subset, filter, na.omit
  • Loading branch information
@felixcheung
felixcheung committed Nov 19, 2015
commit 4bb3b66377694fcf9d64dfaee0b17bc9ba67431a
11 changes: 10 additions & 1 deletion R/pkg/inst/tests/test_sparkSQL.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -760,6 +760,9 @@ test_that("subsetting", {
df6 <- subset(df, df$age %in% c(30), c(1,2))
expect_equal(count(df6), 1)
expect_equal(columns(df6), c("name", "age"))

# Test base::subset is working
expect_equal(nrow(subset(airquality, Temp > 80, select = c(Ozone, Temp))), 68)
})

test_that("selectExpr() on a DataFrame", {
Expand Down Expand Up @@ -1096,7 +1099,7 @@ test_that("group by, agg functions", {
gd3_local <- collect(agg(gd3, var(df8$age)))
expect_equal(162, gd3_local[gd3_local$name == "Justin",][1, 2])

# make sure base:: or stats::sd, var are working
# Test stats::sd, stats::var are working
expect_true(abs(sd(1:2) - 0.7071068) < 1e-6)
expect_true(abs(var(1:5, 1:5) - 2.5) < 1e-6)

Expand Down Expand Up @@ -1148,6 +1151,9 @@ test_that("filter() on a DataFrame", {
expect_equal(count(filtered5), 1)
filtered6 <- where(df, df$age %in% c(19, 30))
expect_equal(count(filtered6), 2)

# Test stats::filter is working
expect_true(is.ts(filter(1:100, rep(1, 3))))
})

test_that("join() and merge() on a DataFrame", {
Expand Down Expand Up @@ -1467,6 +1473,9 @@ test_that("dropna() and na.omit() on a DataFrame", {
expect_identical(expected, actual)
actual <- collect(na.omit(df, minNonNulls = 3, cols = c("name", "age", "height")))
expect_identical(expected, actual)

# Test stats::na.omit is working
expect_equal(nrow(na.omit(data.frame(x = c(0, 10, NA)))), 2)
})

test_that("fillna() on a DataFrame", {
Expand Down