Skip to content

[SPARK-6789] [ML] Add Readable, Writable support for spark.ml ALS, ALSModel #9786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jkbradley wants to merge 2 commits into from
Closed

[SPARK-6789] [ML] Add Readable, Writable support for spark.ml ALS, ALSModel #9786

jkbradley wants to merge 2 commits into from

Conversation

@jkbradley
Copy link
Member

@jkbradley jkbradley commented Nov 18, 2015

Also modifies DefaultParamsWriter.saveMetadata to take optional extra metadata.

CC: @mengxr @yanboliang

@SparkQA
Copy link

SparkQA commented Nov 18, 2015

Test build #46138 has finished for PR 9786 at commit 2bada26.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * class ALS(override val uid: String) extends Estimator[ALSModel] with ALSParams with Writable\n

@yanboliang
Copy link
Contributor

yanboliang commented Nov 18, 2015

Looks good to me.

asfgit pushed a commit that referenced this pull request Nov 18, 2015
@jkbradley @mengxr
[SPARK-6789][ML] Add Readable, Writable support for spark.ml ALS, ALS…
23b8c22 
…Model

Also modifies DefaultParamsWriter.saveMetadata to take optional extra metadata.

CC: mengxr yanboliang

Author: Joseph K. Bradley <[email protected]>

Closes #9786 from jkbradley/als-io.

(cherry picked from commit 2acdf10)
Signed-off-by: Xiangrui Meng <[email protected]>
@mengxr
Copy link
Contributor

mengxr commented Nov 18, 2015

LGTM2. Merged into master and branch-1.6. Thanks!

@asfgit asfgit closed this in 2acdf10 Nov 18, 2015
@jkbradley jkbradley deleted the als-io branch November 18, 2015 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jkbradley @SparkQA @yanboliang @mengxr