Skip to content

Conversation

@cloud-fan
Copy link
Contributor

we use ExpressionEncoder.tuple to build the result encoder, which assumes the input encoder should point to a struct type field if it’s non-flat.
However, our keyEncoder always point to a flat field/fields: groupingAttributes, we should combine them into a single NamedExpression.

@SparkQA
Copy link

SparkQA commented Nov 18, 2015

Test build #46173 has finished for PR 9792 at commit 58509f8.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * public final class UTF8String implements Comparable<UTF8String>, Externalizable, KryoSerializable\n

@SparkQA
Copy link

SparkQA commented Nov 18, 2015

Test build #46202 has finished for PR 9792 at commit 3965292.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * public class JavaGradientBoostedTreeClassifierExample\n * public class JavaGradientBoostedTreeRegressorExample\n * public class JavaRandomForestClassifierExample\n * public class JavaRandomForestRegressorExample\n * case class SerializeWithKryo(child: Expression) extends UnaryExpression\n * case class DeserializeWithKryo[T](child: Expression, tag: ClassTag[T]) extends UnaryExpression\n

@marmbrus
Copy link
Contributor

LGTM, merging into master and 1.6.

asfgit pushed a commit that referenced this pull request Nov 18, 2015
…ression

we use `ExpressionEncoder.tuple` to build the result encoder, which assumes the input encoder should point to a struct type field if it’s non-flat.
However, our keyEncoder always point to a flat field/fields: `groupingAttributes`, we should combine them into a single `NamedExpression`.

Author: Wenchen Fan <[email protected]>

Closes #9792 from cloud-fan/agg.

(cherry picked from commit dbf428c)
Signed-off-by: Michael Armbrust <[email protected]>
@asfgit asfgit closed this in dbf428c Nov 18, 2015
@cloud-fan cloud-fan deleted the agg branch November 19, 2015 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants