Skip to content

[SPARK-11849][SQL] Analyzer should replace current_date and current_timestamp with literals #9833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rxin wants to merge 3 commits into from
+60 −5
Closed

[SPARK-11849][SQL] Analyzer should replace current_date and current_timestamp with literals #9833

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
33013e6
[SPARK-11849][SQL] Analyzer should replace current_date and current_t…
rxin Nov 19, 2015
91f4f68
code review
rxin Nov 19, 2015
1ddbe84
code review 2
rxin Nov 19, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
code review 2
  • Loading branch information
@rxin
rxin committed Nov 19, 2015
commit 1ddbe84505344ce4bbfb7d34fc56d4becfd1f224
3 changes: 2 additions & 1 deletion sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,13 +229,14 @@ class AnalysisSuite extends AnalysisTest {
val max = (System.currentTimeMillis() + 1) * 1000

val lits = new scala.collection.mutable.ArrayBuffer[Long]
plan.transformAllExpressions{ case e: Literal =>
plan.transformAllExpressions { case e: Literal =>
lits += e.value.asInstanceOf[Long]
e
}
assert(lits.size == 2)
assert(lits(0) >= min && lits(0) <= max)
assert(lits(1) >= min && lits(1) <= max)
Copy link
Contributor

@cloud-fan cloud-fan Nov 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also assert that lits(0) == lits(1)?

assert(lits(0) == lits(1))
}

test("analyzer should replace current_date with literals") {
Expand Down