Skip to content

[SPARK-11974][CORE]Not all the temp dirs had been deleted when the JVM exits #9951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pzzs wants to merge 4 commits into from
Closed

[SPARK-11974][CORE]Not all the temp dirs had been deleted when the JVM exits #9951

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0268633
can not use foreach({remove})
pzzs Nov 25, 2015
4ee3a79
Update ShutdownHookManager.scala
pzzs Nov 25, 2015
cea4cd3
add a comment
pzzs Nov 25, 2015
a3e7cb8
add space after //
pzzs Nov 25, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add a comment 
 //we need to materialize the paths to delete because deleteRecursively removes items from
 //shutdownDeletePaths as we are traversing through it.
  • Loading branch information
@pzzs
pzzs committed Nov 25, 2015
commit cea4cd34ca186be1a1733be438e0094ff228f2a9
2 changes: 2 additions & 0 deletions core/src/main/scala/org/apache/spark/util/ShutdownHookManager.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ private[spark] object ShutdownHookManager extends Logging {
// Add a shutdown hook to delete the temp dirs when the JVM exits
addShutdownHook(TEMP_DIR_SHUTDOWN_PRIORITY) { () =>
logInfo("Shutdown hook called")
//we need to materialize the paths to delete because deleteRecursively removes items from
Copy link
Contributor

@rxin rxin Nov 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need a space after // - otherwise this will fail the style check

//shutdownDeletePaths as we are traversing through it.
shutdownDeletePaths.toArray.foreach { dirPath =>
try {
logInfo("Deleting directory " + dirPath)
Expand Down