Skip to content

Enables y-scroll on textarea resize - Fixes issue 132 #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 24 commits into from
Closed

Enables y-scroll on textarea resize - Fixes issue 132 #142

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
4dda831
Enables text area resize
share-with-me Jun 17, 2017
7774619
Fix Travis comments
share-with-me Jun 17, 2017
c380f5f
Remove extra line
share-with-me Jun 18, 2017
92b0716
Switch to sass-lint from scss-lint
sushain97 Jun 18, 2017
f8a476d
Fix sass-lint infractions
sushain97 Jun 19, 2017
7e8f863
Allow no mercy with sass-lint
sushain97 Jun 19, 2017
09860df
Add flake8 to Travis config
sushain97 Jun 19, 2017
f9f50fb
Fix errors reported by flake8
sushain97 Jun 19, 2017
d96550f
Use newer Ubuntu distro for Travis build
sushain97 Jun 19, 2017
7dc9a8e
Enables text area resize
share-with-me Jun 17, 2017
3b7eef3
Fix Travis comments
share-with-me Jun 17, 2017
e175aff
Remove extra line
share-with-me Jun 18, 2017
b87953b
change
share-with-me Jun 19, 2017
3d5b9f6
Fix issue 151
share-with-me Jun 19, 2017
934a87c
Fix issue 151
share-with-me Jun 19, 2017
501aabf
Merge branch 'gsoc-mono-enable-textarea-resize' of https://github.com…
share-with-me Jun 19, 2017
eea5402
Enables text area resize
share-with-me Jun 17, 2017
0e4886f
Fix Travis comments
share-with-me Jun 17, 2017
ffbfd64
Remove extra line
share-with-me Jun 18, 2017
3fab983
change
share-with-me Jun 19, 2017
aa7cce9
Fix issue 151
share-with-me Jun 19, 2017
7d470a4
Fix issue 151
share-with-me Jun 19, 2017
3a024cb
overflow-y hidden
share-with-me Jun 19, 2017
7c56308
Resolve conflicts
share-with-me Jun 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix Travis comments
  • Loading branch information
@share-with-me
share-with-me committed Jun 17, 2017
commit 7774619f7d81a77573d7f462d6f7dab973b0f149
2 changes: 1 addition & 1 deletion assets/js/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ $(document).ready(function () {
return false;
});

$('#originalText').mouseup( function() {
$('#originalText').mouseup(function () {
Copy link
Member

@sushain97 sushain97 Jun 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the mouseup event? Is there not a resize event?

Copy link
Contributor Author

@share-with-me share-with-me Jun 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there not a resize event?

This stackoverflow link discusses about a resize event that we will need to code up to detect a change in textarea dimensions. This too, uses mouseup event only! Thus, I chose to go with the mouseup approach!

if($('#originalText').height() < originalTextScrollHeight) {
Copy link
Member

@sushain97 sushain97 Jun 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to check something like :overflow?

Copy link
Contributor Author

@share-with-me share-with-me Jun 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Um, :overflow to check if the element is having the overflow?

$('#originalText').css('overflow-y', 'scroll');
Copy link
Member

@sushain97 sushain97 Jun 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't this situation be solved with simply a overflow: y-scroll? I'm guessing you've tried it.

Copy link
Contributor Author

@share-with-me share-with-me Jun 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't this situation be solved with simply a overflow: y-scroll?

Um, I had tried that! As soon as synchronizeTextareaHeights method is called, the CSS for this div changes. And thus, I started with this approach of checking if the textarea height falls in the range for scrolling!

}
Expand Down