Skip to content

Spell Checker Interface [WIP] #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
+362 −6
Open

Spell Checker Interface [WIP] #253

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2582df3
Deconflicted #176
JPJPJPOPOP Jan 5, 2018
70f0d63
Fix names.
JPJPJPOPOP Jan 6, 2018
c5ebb87
Fix review comments.
JPJPJPOPOP Jan 6, 2018
74ca4bd
Add flow annotations.
JPJPJPOPOP Jan 6, 2018
810ce86
Minor fixes.
JPJPJPOPOP Jan 7, 2018
63eab87
Fix bug with known words.
JPJPJPOPOP Jan 8, 2018
b6abef3
Fix wrong secondary selection.
JPJPJPOPOP Jan 8, 2018
5c242b2
Nuked secondary selector.
JPJPJPOPOP Jan 9, 2018
4487627
Fixed language localization.
JPJPJPOPOP Jan 9, 2018
2c0791e
Fix empty popover.
JPJPJPOPOP Jan 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix empty popover.
  • Loading branch information
@JPJPJPOPOP
JPJPJPOPOP committed Jan 21, 2018
commit 2c0791e8f53b9f9fc6c52350ee29c71a4e592b2e
30 changes: 20 additions & 10 deletions assets/js/spellchecker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
var spellers = {}, spellerData = {};
var currentSpellCheckerRequest;

/* exported getSpellers, spellerData */
/* exported getSpellers, spellerData, populatePrimarySpellCheckerList */
/* global config, modeEnabled, persistChoices, readCache, ajaxSend, ajaxComplete, filterLangPairList, allowedLang, cache,
localizeInterface, getLangByCode, restoreChoices, callApy */
Copy link

@houndci-bot houndci-bot Jan 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'callApy' is defined but never used no-unused-vars

/* global ENTER_KEY_CODE */
Expand Down Expand Up @@ -200,15 +200,25 @@ function check() {
}
$('.spellError').each(function () {
var currentTokenId = this.id;
$(this).popover({
animation: false,
placement: 'bottom',
trigger: 'manual',
html: true,
content: content[currentTokenId]
});
if(content[currentTokenId].indexOf('spellCheckerListItem') !== -1) {
$(this).popover({
animation: false,
placement: 'bottom',
trigger: 'manual',
html: true,
content: content[currentTokenId]
});
}
else {
$(this).popover({
animation: false,
placement: 'bottom',
trigger: 'manual',
html: true,
content: '<div style="padding: 4px 10px; color: #b94a48;">No spelling suggestions</div>'
});
}
});

},
error: handleSpellCheckerErrorResponse,
complete: function () {
Expand All @@ -227,7 +237,7 @@ function spellCheckerNotAvailable(data) {
$('#spellCheckerInput').append($('<div></div>').text(data.explanation));
}

/*:: export {getSpellers, spellerData} */
/*:: export {getSpellers, spellerData, populatePrimarySpellCheckerList} */

/*:: import {modeEnabled, ajaxSend, ajaxComplete, allowedLang, filterLangPairList, callApy, ENTER_KEY_CODE} from "./util.js" */
/*:: import {persistChoices, restoreChoices} from "./persistence.js" */
Expand Down