-
Notifications
You must be signed in to change notification settings - Fork 4
feat(webhook-callbacks): add support for verifying http request signatures #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hamzamahmood
merged 9 commits into
main
from
feat-add-signature-verification-http-request
Oct 1, 2025
Merged
feat(webhook-callbacks): add support for verifying http request signatures #144
hamzamahmood
merged 9 commits into
main
from
feat-add-signature-verification-http-request
Oct 1, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tures - Adds a ISignatureVerifier contract for custom signature verification - Adds configurable HMAC signature verification - Adds test for signature verification - Adds DigestCodec hex, Base64 and Base64Url support
…block for _digestCodec
- add tests for HmacFactory - add unit test for ExpectedTemplate and SignatureValue
sufyankhanrao
requested changes
Sep 23, 2025
APIMatic.Core/Security/SignatureVerifier/SignatureVerifierExtensions.cs
Outdated
Show resolved
Hide resolved
APIMatic.Core/Security/SignatureVerifier/SignatureVerifierExtensions.cs
Outdated
Show resolved
Hide resolved
APIMatic.Core/Security/SignatureVerifier/HmacSignatureVerifier.cs
Outdated
Show resolved
Hide resolved
|
sufyankhanrao
approved these changes
Oct 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
To ensure secure handling of incoming webhook and callback requests, we need to validate their authenticity. Without signature verification, there is a risk of processing spoofed or tampered requests. Adding a standard verification mechanism also makes it easier to plug in custom verification strategies as needed.
What
Type of change
Select multiple if applicable.
Testing
Unit tests for the signature verification have been added
Checklist