Skip to content

Conversation

jonoskar
Copy link
Contributor

A different data scheme than Arion, M5 and Landsbankinn. However, Borgun API has far more currencies to offer so it's definitely a valuable provider.

Sample response:

results: [
    {
        currencyCode: "ALL",
        currencyDescription: "lek",
        currencyRate: 1.08005,
        country: "Albanía",
        countryEnglish: "Albania",
        countryCode: "ALB",
        rateDate: "10.2.2016"
    },
    {
        currencyCode: "DZD",
        currencyDescription: "denari, alsírskur",
        currencyRate: 1.25288,
        country: "Alsír",
        countryEnglish: "Algeria",
        countryCode: "DZA",
        rateDate: "10.2.2016"
    }
]

@jonoskar
Copy link
Contributor Author

Yeah... I have nothing to do with those failing tests 😁

@koddsson
Copy link
Member

LGTM

koddsson added a commit that referenced this pull request Feb 11, 2016
Added Borgun provider to the currency endpoint
@koddsson koddsson merged commit 65a8c3f into apis-is:master Feb 11, 2016
@kristjanmik
Copy link
Member

Great job @jonoskar! Thanks for contributing 👍
The endpoint will not be deployed unless we fix the tests. I will take a look over the weekend.

@kristjanmik
Copy link
Member

Me and @koddsson did some shovelling and your code is now in production at https://apis.is/currency/borgun 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants