-
Notifications
You must be signed in to change notification settings - Fork 63
Add a metrics middleware to app #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Nice! |
Oh, yeah. I didn't think of that 😁 |
Maybe it's better to send 'em to a statsd server since the lib has support for that. I'll check if we can do that easily. |
It is probably better to did this in front of the application layer itself. I was taking a look at https://getkong.org the other day and it seems like the perfect fit for us. Then all this logging comes for free. |
@kristjanmik If we do something like kong, we'd just have to add it to our infrastructure? |
In any case should we merge this for now and then iterate on it? There's instant value to be had even if we lose the data once we restart the app and if it proves valuable we can go with either something like kong or start shipping the data to some server for safe keeping. |
Also kong looks really nice! 🐵 |
I agree, I'm merging this in! |
Add a metrics middleware to app
I assume the port is not exposed? Maybe we should just add it to the nginx config as a path? |
Where does the nginx config live? |
Jeee! |
Could you do that real quick? 🙏 |
Sure |
You da 💣 ! |
Fixes #245!
Collects metrics and makes 'em available on port 8091 under
/metrics
.