-
Notifications
You must be signed in to change notification settings - Fork 63
feat: generate documentation from markdown files #378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This looks great! Have you thought about how we should implement this as our main doc? |
I was thinking about utilizing ghpages to deploy to Github Pages on each build. |
I added all the docs that currently exists on I kind of want to merge this as is and make a header and footer in another PR as well as more tools to make writing docs even easier. |
How flexible is this? Could it be possible to add some functionality to the docs in the future so it's not just a static page? Like doing real calls to the API to load responses. Possible to add a sidebar? I have no experience with |
@MiniGod Sure! Since apis.is is CORS enabled we can just add some javascript to fetch the resources. Since the markdown standard allows arbitrary HTML we can basically do everything we want in the docs. |
Oh that's cool! Didn't know that was a option! So what |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This hasn't gotten any comments in a while and since it's adding stuff and not removing anything I'm gonna move this forward and merge this after resolving the conflict. |
Not sure why the tests are loading the markdown files. Looking at that now. |
I think the currency endpoint might need test fixtures, it seems to be breaking a from day to day making me think there are some time sensitive data being saved somehow. Not sure how it would fail the tests but I'm gonna keep 👀 on it. |
Here's a PR for how I see the documentation being in the future. It seems that our documentation is kind of lost somewhere(?) and I thought I'd take a stab at making a super simple documentation framework.
documentation.md
file in the endpoint folder?)I figured I'd open this PR to keep my work out in the open and am interested in any feedback on stuff you really feel like should be in a documentation framework for us.