Skip to content

Conversation

koddsson
Copy link
Member

I was doing some exploring and found xo and it looks pretty neat to me. The biggest drawback seems to be that you need to add a xo plugin to your $EDITOR but if that's a big drawback I think we could just extend eslint-config-xo.

I disabled most of the rules but left those that didn't need a lot of work and made sense to me and fixed the issues that xo was reporting.

Copy link
Member

@benediktvaldez benediktvaldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benediktvaldez
Copy link
Member

Large changeset and doesn't really matter IMHO. XO is great for exactly that reason.

My vote is to fix the conflicts and merge asap

@koddsson
Copy link
Member Author

koddsson commented Nov 7, 2017

@benediktvaldez What do you think about people needing to config a different flow for their editor to use xo over eslint?

@benediktvaldez
Copy link
Member

The simplest way to solve that would be to create a .eslintrc file in the root with

{
	"extends": "xo"
}

This should work in most editors that support eslint

@koddsson
Copy link
Member Author

koddsson commented Nov 8, 2017

Ah lol, of course 😄

@koddsson
Copy link
Member Author

koddsson commented Nov 8, 2017

I say we go for this and then we can change to the xo-config if we want to

@koddsson
Copy link
Member Author

koddsson commented Nov 8, 2017

Nothing changed in the tests here which makes me believe that the tests might be flaky after #403 😭

…with-xo

# Conflicts:
#	package-lock.json
#	package.json
@koddsson koddsson merged commit 1fb161a into apis-is:master Dec 28, 2017
@koddsson koddsson deleted the replace-eslint-with-xo branch December 28, 2017 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants