-
Notifications
You must be signed in to change notification settings - Fork 63
Replace eslint with xo #397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Large changeset and doesn't really matter IMHO. XO is great for exactly that reason. My vote is to fix the conflicts and merge asap |
@benediktvaldez What do you think about people needing to config a different flow for their editor to use |
The simplest way to solve that would be to create a
This should work in most editors that support eslint |
Ah lol, of course 😄 |
I say we go for this and then we can change to the |
Nothing changed in the tests here which makes me believe that the tests might be flaky after #403 😭 |
…with-xo # Conflicts: # package-lock.json # package.json
I was doing some exploring and found xo and it looks pretty neat to me. The biggest drawback seems to be that you need to add a
xo
plugin to your$EDITOR
but if that's a big drawback I think we could just extendeslint-config-xo
.I disabled most of the rules but left those that didn't need a lot of work and made sense to me and fixed the issues that
xo
was reporting.