Skip to content

chore(package): update sinon to version 5.0.3 #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2018
Merged

chore(package): update sinon to version 5.0.3 #452

merged 1 commit into from
May 2, 2018

Conversation

koddsson
Copy link
Member

@koddsson koddsson commented May 2, 2018

Closes #451

@koddsson koddsson merged commit 8aa6527 into master May 2, 2018
@koddsson koddsson deleted the greenkeeper/sinon-5.0.3 branch May 2, 2018 12:34
@MiniGod
Copy link
Member

MiniGod commented May 3, 2018

Hey @koddsson! Great that you're taking the time to go through these.

Don't we have to update the package-lock.json file after merging these prs?

@koddsson
Copy link
Member Author

koddsson commented May 3, 2018

Oh shit I forgot that greenkeeper doesn't do that. Good shout, I'll try to remember to do that tomorrow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benediktvaldez benediktvaldez Awaiting requested review from benediktvaldez benediktvaldez is a code owner

@kristjanmik kristjanmik Awaiting requested review from kristjanmik kristjanmik is a code owner

@MiniGod MiniGod Awaiting requested review from MiniGod MiniGod is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koddsson @MiniGod